Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List Block: Implement block switcher API #766

Merged
merged 2 commits into from
May 15, 2017
Merged

Conversation

youknowriad
Copy link
Contributor

closes #704

Implements switching a list to text, heading or quote block.

@youknowriad youknowriad added the [Feature] Blocks Overall functionality of blocks label May 11, 2017
@youknowriad youknowriad self-assigned this May 11, 2017
@youknowriad youknowriad requested a review from jasmussen May 11, 2017 09:47
@jasmussen
Copy link
Contributor

Works great!

Are we sure we want Heading as a possible transformation here? I do realize this goes back to the discussion we had about converting text to a heading, and I'm okay not rehashing that — but it feels a little extra weird here, where only the first list item is converted to a heading.

I'm okay with either, we can always revisit later on if we find it weird, but I figured I'd ask the question.

@youknowriad
Copy link
Contributor Author

Are we sure we want Heading as a possible transformation here?

Your choice.

@jasmussen
Copy link
Contributor

Your choice.

💥

Let's remove it from the list for now. If you want to, you can convert to text first, then to heading. Thanks Riad!

@aduth
Copy link
Member

aduth commented May 11, 2017

Related: #689 (concatChildren proposed to be removed)

@youknowriad
Copy link
Contributor Author

If anyone want to take a final look, I'll be merging this later.

@aduth
Copy link
Member

aduth commented May 15, 2017

Noting my reluctance to further build upon APIs we've identified as problematic, while also acknowledging that alternatives have yet to be fleshed out.

More at #689 (comment), #771

@youknowriad
Copy link
Contributor Author

Yes, we'll have to reconsider these helper functions once we address #771

@youknowriad youknowriad merged commit 65a9424 into master May 15, 2017
@youknowriad youknowriad deleted the add/list-block-switcher branch May 15, 2017 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List Block: Support Switcher
3 participants